Skip to content

Add myself to the review rotation #148039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

Add myself to the review rotation #148039

merged 1 commit into from
Oct 24, 2025
+1 −0

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Oct 23, 2025 •
edited
Loading

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@JonathanBrouwer
Copy link
Contributor Author

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 23, 2025

📌 Commit 9ceb997 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#148039 - JonathanBrouwer:add-myself, r=Jona…
d569533 
…thanBrouwer

Add myself to the review rotation
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 23, 2025
Closed
bors added a commit that referenced this pull request Oct 23, 2025
@bors
Auto merge of #148041 - matthiaskrgr:rollup-ysofz8z, r=matthiaskrgr
72fab81 
Rollup of 3 pull requests

Successful merges:

 - #148018 (fix panic when rustc tries to reduce intermediate filenames len with utf8)
 - #148030 (Add Marijn Schouten to .mailmap)
 - #148039 (Add myself to the review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 23, 2025
@Zalathar
Rollup merge of rust-lang#148039 - JonathanBrouwer:add-myself, r=Jona…
a6096c7 
…thanBrouwer

Add myself to the review rotation
@Zalathar Zalathar mentioned this pull request Oct 23, 2025
Closed
bors added a commit that referenced this pull request Oct 24, 2025
@bors
Auto merge of #148055 - Zalathar:rollup-7y9yo35, r=Zalathar
80d46c5 
Rollup of 3 pull requests

Successful merges:

 - #148016 (Revert constification of `Borrow` and `Deref for Cow` due to inference failure)
 - #148039 (Add myself to the review rotation)
 - #148042 (test(frontmatter): Cover spaces between infostring parts)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Oct 24, 2025
Merged
bors added a commit that referenced this pull request Oct 24, 2025
@bors
Auto merge of #148059 - Zalathar:rollup-zkk5prm, r=Zalathar
75948c8 
Rollup of 5 pull requests

Successful merges:

 - #148016 (Revert constification of `Borrow` and `Deref for Cow` due to inference failure)
 - #148021 ([rustdoc] Simplify module rendering and HTML tags handling)
 - #148039 (Add myself to the review rotation)
 - #148042 (test(frontmatter): Cover spaces between infostring parts)
 - #148054 (Streamline iterator chaining when computing successors.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 439d374 into rust-lang:master Oct 24, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 24, 2025
rust-timer added a commit that referenced this pull request Oct 24, 2025
@rust-timer
Unrolled build for #148039
6d6cea9 
Rollup merge of #148039 - JonathanBrouwer:add-myself, r=JonathanBrouwer

Add myself to the review rotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rustbot @bors @Mark-Simulacrum